Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/20731 )
Change subject: IMPALA-12502: Support Impala to Impala federation ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/20731/9/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfig.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfig.java: http://gerrit.cloudera.org:8080/#/c/20731/9/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfig.java@21 PS9, Line 21: public enum JdbcStorageConfig { Would be good to also support setting query options for Impala in the JdbcStorageConfig as that's pretty common usecase and something we support setting from jdbc client. Could be a follow on task. http://gerrit.cloudera.org:8080/#/c/20731/9/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables.test File testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables.test: http://gerrit.cloudera.org:8080/#/c/20731/9/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables.test@80 PS9, Line 80: where float_col = 0 and string_col is not NULL These predicates seem to be evaluated locally and not in the remote Impala? Either way would be good to also validate in the profile where predicate is applied. Same comment for other such queries. -- To view, visit http://gerrit.cloudera.org:8080/20731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79ad3273932b658cb85c9c17cc834fa1b5fbd64f Gerrit-Change-Number: 20731 Gerrit-PatchSet: 9 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Dec 2023 23:28:07 +0000 Gerrit-HasComments: Yes
