Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20793 )

Change subject: IMPALA-12606: Sporadic failures around 
query_test.test_queries.TestQueries.test_intersect
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20793/4/be/src/exec/hash-table.cc
File be/src/exec/hash-table.cc:

http://gerrit.cloudera.org:8080/#/c/20793/4/be/src/exec/hash-table.cc@281
PS4, Line 281:     RawValue::WriteNonNullPrimitive(val, loc, expr_type, NULL, 
/*hash_table_null=*/true);
> FNV_SEED is larger than INT_MAX, so in signed int32_t it became negative. T
Ack



--
To view, visit http://gerrit.cloudera.org:8080/20793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b855c59808db80fd7ac596ce338fc4c3c9c7667
Gerrit-Change-Number: 20793
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 15 Dec 2023 23:51:27 +0000
Gerrit-HasComments: Yes

Reply via email to