Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20810 )
Change subject: WIP: Skip KRPC in local exchanges ...................................................................... Patch Set 3: (14 comments) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-recvr.cc@338 PS3, Line 338: if (payload->rpc_context != nullptr) TRACE_TO(payload->rpc_context->trace(), "Enqueuing deferred RPC"); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-recvr.cc@488 PS3, Line 488: //TRACE_TO(rpc_context->trace(), "Failed to deserialize batch: $0", status.GetDetail()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-recvr.cc@638 PS3, Line 638: if (ctx->rpc_context != nullptr) TRACE_TO(ctx->rpc_context->trace(), "Batch queue is full"); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-recvr.cc@661 PS3, Line 661: if (ctx->rpc_context != nullptr) recvr_->deferred_rpc_tracker()->Release(ctx->rpc_context->GetTransferSize()); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-recvr.cc@666 PS3, Line 666: if (ctx->rpc_context != nullptr) DataStreamService::RespondRpc(status, ctx->response, ctx->rpc_context); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-recvr.cc@773 PS3, Line 773: //LOG(INFO) << "KrpcDataStreamRecvr::SenderQueue::Close() data_arrival_cv_.wait(l) finished"; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-sender.cc@174 PS3, Line 174: Status Init(RuntimeState* state, std::shared_ptr<CharMemTrackerAllocator> allocator, bool partitioned); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-sender.cc@388 PS3, Line 388: RuntimeState* state, std::shared_ptr<CharMemTrackerAllocator> allocator, bool partitioned) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-sender.cc@665 PS3, Line 665: RETURN_IF_ERROR(parent_->SerializeBatch(batch, serialization_batch->get(), !is_local_)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/krpc-data-stream-sender.cc@900 PS3, Line 900: RETURN_IF_ERROR(channels_[i]->Init(state, char_mem_tracker_allocator_, partition_type_ != TPartitionType::UNPARTITIONED)); line too long (126 > 90) http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/local-row-batch-channel.h File be/src/runtime/local-row-batch-channel.h: http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/local-row-batch-channel.h@38 PS3, Line 38: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/local-row-batch-channel.cc File be/src/runtime/local-row-batch-channel.cc: http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/local-row-batch-channel.cc@43 PS3, Line 43: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/local-row-batch-channel.cc@85 PS3, Line 85: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/3/be/src/runtime/local-row-batch-channel.cc@146 PS3, Line 146: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/20810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee16cd943d76d04874bce7f3959e74b4685adb6e Gerrit-Change-Number: 20810 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 17 Dec 2023 12:32:43 +0000 Gerrit-HasComments: Yes
