Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20799 )
Change subject: IMPALA-12633: Remove DCHECK for slow SetQueryInflight ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/20799/5/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20799/5/be/src/service/client-request-state.cc@179 PS5, Line 179: BlockOnWait() This error message is stale and misleading. This line was added in commit bf8e1b8. At that time, BlockOnWait() calls wait_thread.reset(). But now wait_thread_ is only reset in Finalized(). I think we should change this to "Finalized()". http://gerrit.cloudera.org:8080/#/c/20799/5/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/20799/5/be/src/service/impala-server.h@764 PS5, Line 764: /// in-flight until the query is unregistered. Until a query is in-flight, an attempt It'd be nice to also mention prestopped_queries. http://gerrit.cloudera.org:8080/#/c/20799/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/20799/4/be/src/service/impala-server.cc@1615 PS4, Line 1615: query_handle->session()->prestopped_queries.insert(query_handle->query_id()); > I don't think we'll ever call CloseClientRequestState twice. That would mes We can check whether the insertion took place and add a warning log if it doesn't. The return value of set::insert() can be used. http://gerrit.cloudera.org:8080/#/c/20799/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/20799/5/be/src/service/impala-server.cc@1616 PS5, Line 1616: ++query_handle->session()->total_queries; Could you add a comment here for why we bump the counter when closing a query? -- To view, visit http://gerrit.cloudera.org:8080/20799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7 Gerrit-Change-Number: 20799 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 18 Dec 2023 11:23:51 +0000 Gerrit-HasComments: Yes
