Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10210 )

Change subject: IMPALA-6885: handle empty s3 dirs in recover_partitions test
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10210/1/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:

http://gerrit.cloudera.org:8080/#/c/10210/1/tests/metadata/test_recover_partitions.py@368
PS1, Line 368:     # Adds partition directories.
> do we really need 700? seems like a lot
dialed it down (that number was from the test above)


http://gerrit.cloudera.org:8080/#/c/10210/1/tests/metadata/test_recover_partitions.py@395
PS1, Line 395:        filesystems."""
> os.path.join?
Done



--
To view, visit http://gerrit.cloudera.org:8080/10210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6c74f4f2466b5870322bdf373e8a6a4d1d679f4
Gerrit-Change-Number: 10210
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
Gerrit-Comment-Date: Thu, 26 Apr 2018 01:33:21 +0000
Gerrit-HasComments: Yes

Reply via email to