Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20818 )

Change subject: IMPALA-12653: Update documentation about the UPDATE statement
......................................................................


Patch Set 4:

(3 comments)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/20818/2/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:

http://gerrit.cloudera.org:8080/#/c/20818/2/docs/topics/impala_iceberg.xml@506
PS2, Line 506: doesn
> doesn't
Done


http://gerrit.cloudera.org:8080/#/c/20818/2/docs/topics/impala_iceberg.xml@512
PS2, Line 512: Only the merge-on-read update mode is supported
> nit: If the list items are full sentences, it is nicer to end each with a p
Done


http://gerrit.cloudera.org:8080/#/c/20818/2/docs/topics/impala_iceberg.xml@515
PS2, Line 515:           <li>
> So if the table is ORC then we write Parquet delete files? If so then a few
If write.format.default or write.delete.format.default are set to ORC, or 
basically anything other than PARQUET, we raise an error. I updated the docs.



--
To view, visit http://gerrit.cloudera.org:8080/20818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a4f3dcdba5faaa7dffda60b8590d09e6a92a165
Gerrit-Change-Number: 20818
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 20 Dec 2023 12:22:06 +0000
Gerrit-HasComments: Yes

Reply via email to