Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20482 )
Change subject: IMPALA-12431: Support reading compressed JSON file ...................................................................... Patch Set 8: Code-Review+1 (2 comments) The patch looks pretty good to me. Just have some minor comments. http://gerrit.cloudera.org:8080/#/c/20482/8/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: http://gerrit.cloudera.org:8080/#/c/20482/8/be/src/exec/hdfs-scanner.h@541 PS8, Line 541: /// available decompressed data. nit: any reason for removing this comment? /// Attaches decompression buffers from previous calls that might still be referenced /// by returned batches to 'pool'. If 'pool' is nullptr the buffers are freed instead. http://gerrit.cloudera.org:8080/#/c/20482/8/be/src/exec/json/hdfs-json-scanner.cc File be/src/exec/json/hdfs-json-scanner.cc: http://gerrit.cloudera.org:8080/#/c/20482/8/be/src/exec/json/hdfs-json-scanner.cc@90 PS8, Line 90: template_tuple_pool_ nit: do you mean 'row_batch'? -- To view, visit http://gerrit.cloudera.org:8080/20482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2471855d97d4cdd51363b321055e6b06aa6d81e8 Gerrit-Change-Number: 20482 Gerrit-PatchSet: 8 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Sun, 31 Dec 2023 01:51:07 +0000 Gerrit-HasComments: Yes
