Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20825 )
Change subject: IMPALA-12658: UPDATE Iceberg table FROM view throws IllegalStateException ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Thank you for the fix. I left 2 nits, otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/20825/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20825/1//COMMIT_MSG@11 PS1, Line 11: substituted substitute http://gerrit.cloudera.org:8080/#/c/20825/1/fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java File fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java: http://gerrit.cloudera.org:8080/#/c/20825/1/fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java@62 PS1, Line 62: involved the nit: involved, the -- To view, visit http://gerrit.cloudera.org:8080/20825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80ccdb61327a50082f792a6d51f946b11c467dab Gerrit-Change-Number: 20825 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Jan 2024 11:47:21 +0000 Gerrit-HasComments: Yes
