Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20850 )
Change subject: IMPALA-12533: Support row materialization outside of fetch lock ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-options.h@53 PS1, Line 53: TImpalaQueryOptions::DELAY_MATERIALIZE_RESULTS_THRESHOLD + 1); \ line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-result-set.cc File be/src/service/query-result-set.cc: http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-result-set.cc@90 PS1, Line 90: mem_tracker_.reset(new MemTracker((impala::IntGauge*)nullptr, -1, "Result row batch", state_->query_mem_tracker())); line too long (120 > 90) http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-result-set.cc@91 PS1, Line 91: expr_mem_tracker_.reset(new MemTracker((impala::IntGauge*)nullptr, -1, "Result expr", mem_tracker_.get())); line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-result-set.cc@108 PS1, Line 108: size_t size() const { return pendingRowBatch_ ? pendingRowBatch_.get()->num_rows() : 0; } line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-result-set.cc@189 PS1, Line 189: virtual size_t size() override { return row_batch_context_ ? row_batch_context_->size() : num_rows_; } line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-result-set.cc@193 PS1, Line 193: virtual bool DelayedMaterializationEnabled() const override { return delay_materialization_; } line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-result-set.cc@280 PS1, Line 280: metadata, rowset, stringify_map_keys, expected_result_count, delay_materialization); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20850/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/20850/1/tests/query_test/test_observability.py@674 PS1, Line 674: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/20850/1/tests/query_test/test_observability.py@685 PS1, Line 685: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/20850/1/tests/query_test/test_observability.py@694 PS1, Line 694: ; flake8: E703 statement ends with a semicolon -- To view, visit http://gerrit.cloudera.org:8080/20850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9512aa6022dbcf81e7eb5f559853b89fe80bd23 Gerrit-Change-Number: 20850 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 03 Jan 2024 23:23:35 +0000 Gerrit-HasComments: Yes
