Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20856 )

Change subject: IMPALA-12676: Fix integer overflow in DatabaseTest
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20856/2/be/src/service/internal-server-test.cc
File be/src/service/internal-server-test.cc:

http://gerrit.cloudera.org:8080/#/c/20856/2/be/src/service/internal-server-test.cc@152
PS2, Line 152:           u_int32_t first_sold = secs_per_year * (cat * cat);
> Please use uint32_t. u_int32_t is non-standard.
Done.  Fixed other places too.



--
To view, visit http://gerrit.cloudera.org:8080/20856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3689185aa8676203226cc447585703e784627102
Gerrit-Change-Number: 20856
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Thu, 04 Jan 2024 17:52:04 +0000
Gerrit-HasComments: Yes

Reply via email to