Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10218 )
Change subject: IMPALA-6934: Wrong results with EXISTS subquery containing ORDER BY, LIMIT, and OFFSET ...................................................................... IMPALA-6934: Wrong results with EXISTS subquery containing ORDER BY, LIMIT, and OFFSET Queries may return wrong results if an EXISTS subquery has an ORDER BY with a LIMIT and OFFSET clause. The EXISTS subquery may incorrectly evaluate to TRUE even though it is FALSE. The bug was found during the code review of IMPALA-6314 (https://gerrit.cloudera.org/#/c/9005/). Turned out QueryStmt.setLimit() wipes the offset. I modified it to keep the offset expr. Added tests to 'PlannerTest/subquery-rewrite.test' and 'QueryTest/subquery.test' Change-Id: I9693623d3d0a8446913261252f8e4a07935645e0 Reviewed-on: http://gerrit.cloudera.org:8080/10218 Reviewed-by: Alex Behm <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/QueryStmt.java M testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test M testdata/workloads/functional-query/queries/QueryTest/subquery.test 3 files changed, 37 insertions(+), 2 deletions(-) Approvals: Alex Behm: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9693623d3d0a8446913261252f8e4a07935645e0 Gerrit-Change-Number: 10218 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
