Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20367 )
Change subject: IMPALA-10976: Sync db/table to latest HMS event for all DDL/DMLs ...................................................................... Patch Set 24: (1 comment) http://gerrit.cloudera.org:8080/#/c/20367/24/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/20367/24/tests/metadata/test_ddl.py@156 PS24, Line 156: @ > flake8: F811 redefinition of unused 'test_truncate_cleans_hdfs_files' from Can we address this by using a different name, e.g. "_test_truncate_cleans_hdfs_files_helper", or "_test_truncate_cleans_hdfs_files_impl"? BTW, the helper function name shouldn't start with "test". Otherwise, pytest will consider it as a test. https://docs.pytest.org/en/7.4.x/explanation/goodpractices.html#conventions-for-python-test-discovery -- To view, visit http://gerrit.cloudera.org:8080/20367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia250d0a943838086c187e5cb7c60035e5a564bbf Gerrit-Change-Number: 20367 Gerrit-PatchSet: 24 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 05 Jan 2024 23:01:22 +0000 Gerrit-HasComments: Yes
