Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20869 )
Change subject: [PROTOTYPE] Add ability to use GDB to resolve stacks for a minidump ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/20869/1/bin/resolve_minidumps.py File bin/resolve_minidumps.py: http://gerrit.cloudera.org:8080/#/c/20869/1/bin/resolve_minidumps.py@47 PS1, Line 47: import time flake8: F401 'time' imported but unused http://gerrit.cloudera.org:8080/#/c/20869/1/bin/resolve_minidumps.py@323 PS1, Line 323: _ flake8: E501 line too long (120 > 90 characters) http://gerrit.cloudera.org:8080/#/c/20869/1/bin/resolve_minidumps.py@333 PS1, Line 333: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/20869/1/bin/resolve_minidumps.py@343 PS1, Line 343: i flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/20869/1/bin/resolve_minidumps.py@392 PS1, Line 392: flake8: E501 line too long (121 > 90 characters) http://gerrit.cloudera.org:8080/#/c/20869/1/bin/resolve_minidumps.py@421 PS1, Line 421: , flake8: E501 line too long (108 > 90 characters) http://gerrit.cloudera.org:8080/#/c/20869/1/bin/resolve_minidumps.py@446 PS1, Line 446: ) flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/20869/1/lib/python/impala_py_lib/gdb/impala-gdb.py File lib/python/impala_py_lib/gdb/impala-gdb.py: http://gerrit.cloudera.org:8080/#/c/20869/1/lib/python/impala_py_lib/gdb/impala-gdb.py@27 PS1, Line 27: def get_thread_names(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20869/1/lib/python/impala_py_lib/gdb/impala-gdb.py@157 PS1, Line 157: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/20869/1/lib/python/impala_py_lib/gdb/impala-gdb.py@195 PS1, Line 195: t flake8: E111 indentation is not a multiple of 2 -- To view, visit http://gerrit.cloudera.org:8080/20869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic61cc69df0e43cb1d0049f273190d5384b54fc8e Gerrit-Change-Number: 20869 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 08 Jan 2024 18:40:16 +0000 Gerrit-HasComments: Yes
