Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20870
Change subject: IMPALA-12686: Build the toolchain with basic debug information (-g1) ...................................................................... IMPALA-12686: Build the toolchain with basic debug information (-g1) Basic debug information (e.g. -g1) is useful for getting better stack traces. Compressing debug information (-gz) reduces the size of this debug information dramatically. This adds both -g1 and -gz to the default flags for the toolchain. In order to have the flags apply uniformly, components need to respect the existing CFLAGS and CXXFLAGS. Several components were setting their own CFLAGS and CXXFLAGS without keeping the existing flags, so this fixes the components to keep existing flags. Some components build with an extra -g after our flags and these continue to build this way. Specifically, the following using -g: - Thrift (-g added in this change) - Kudu - ORC - CCTZ - bzip2 These keep the same debug information they had before, except that -gz compresses it now. This change should not reduce the debug information for any component. This turns off debug information for CMake as it is just a build tool and doesn't need it. Testing: - Ran a build and examined what happened to the package sizes. Change-Id: Iee2e264b281f83ebc226d9bf7d4e5a99a52f1fc6 --- M init-compiler.sh M source/arrow/build.sh M source/bzip2/build.sh M source/cmake/build.sh M source/curl/build.sh M source/flatbuffers/build.sh M source/gflags/build.sh M source/glog/build.sh M source/lz4/build.sh M source/orc/build.sh M source/python/build.sh M source/thrift/build.sh 12 files changed, 27 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/70/20870/1 -- To view, visit http://gerrit.cloudera.org:8080/20870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iee2e264b281f83ebc226d9bf7d4e5a99a52f1fc6 Gerrit-Change-Number: 20870 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]>
