Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/20837 )
Change subject: IMPALA-12642: Support query options for Impala external JDBC table ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20837/3/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfig.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfig.java: http://gerrit.cloudera.org:8080/#/c/20837/3/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfig.java@51 PS3, Line 51: // A comma in string type of value must be encoded as %2C. Are there any query options which use comma in the values today? If so would be good to write a test case for that. -- To view, visit http://gerrit.cloudera.org:8080/20837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47687b7a93e90cea8ebd5f3fc280c9135bd97992 Gerrit-Change-Number: 20837 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Thu, 11 Jan 2024 21:43:42 +0000 Gerrit-HasComments: Yes
