Yida Wu has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/20898


Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky 
tests
......................................................................

IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests

The introduction of check_deleted_file_fd() in IMPALA-12681 aimed
to detect a bug related to remote splling where local temporary file
handles were not being released after deletion. However, the tests
associated with this function seem flaky in exhaustive builds with
occasionally some files of hdfs may not be promptly released after
deletion, though locally, I observed that these files are eventually
removed from /proc/xx/fd in a few minutes, the reason is unclear
yet.

To fix the flaky build failure, this patch confines the scope of
check_deleted_file_fd() to detect files containing the keyword
"scratch" only. Given that hdfs files eventually get removed, and
it seems not an urgent issue, a separate Jira will be filed to track
and investigate this behavior further.

Testing:
Reran the tests a couple times and passed.

Change-Id: I55f5aa1cdbc0c74f6c7ebd25575e71d2b238bf98
---
M tests/custom_cluster/test_scratch_disk.py
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/20898/1
--
To view, visit http://gerrit.cloudera.org:8080/20898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55f5aa1cdbc0c74f6c7ebd25575e71d2b238bf98
Gerrit-Change-Number: 20898
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

Reply via email to