Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/client-request-state.h@25 PS5, Line 25: #include "service/child-query.h" > Fixed. Ack http://gerrit.cloudera.org:8080/#/c/20770/7/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/20770/7/be/src/service/impala-server.h@1849 PS7, Line 1849: /// Required data will be copied from the provided ClientRequestState into members of I'd prefer we make sure QueryStateExpanded is always well-formed. The constructor should require shared_ptr<QueryStateRecord> as an argument (could have an option to create one if nullptr, but not sure we need it). http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/impala-server.h@1644 PS5, Line 1644: > I tried to create a new header file, but the circular dependencies made it What circular dependencies? http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/query-state.cc File be/src/service/query-state.cc: http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/query-state.cc@151 PS5, Line 151: // Fields from the schedule. > Good point. Fixed. Ack http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/workload-management.cc@597 PS5, Line 597: // TODO: should qs_rec be moved? > Done Ack http://gerrit.cloudera.org:8080/#/c/20770/7/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/7/be/src/service/workload-management.cc@598 PS7, Line 598: exp_rec->base_state = qs_rec; Moving would make sense. You don't need to pass it to the function as const either. http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/util/ticker.h File be/src/util/ticker.h: http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/util/ticker.h@72 PS5, Line 72: return Thread::Create(category, name, boost::bind<void>(&Ticker::run, this), > Done Ack -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 16 Jan 2024 22:00:53 +0000 Gerrit-HasComments: Yes
