Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 )
Change subject: IMPALA-6522: [DOCS] Document Decimal V2 ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml@526 PS9, Line 526: 38,0 We should be consistent about putting a space after the comma. Either put it everywhere in the DOC or don't put it everywhere. http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml@654 PS9, Line 654: is the INT : type with the precision 10. ... because all digits do not fit into DECIMAL(3,0) http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml@681 PS9, Line 681: There should be no space before the open brace. Here and elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 9 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Fri, 27 Apr 2018 19:21:58 +0000 Gerrit-HasComments: Yes
