Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20918 )
Change subject: IMPALA-12038: Switch report_benchmark_results.py to python 3 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20918/1/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: http://gerrit.cloudera.org:8080/#/c/20918/1/tests/benchmark/report_benchmark_results.py@323 PS1, Line 323: ref_time_list.append(ref_query_results[TIME_TAKEN]) : : : self.workload_name = '{0}({1})'.format( nit: is it OK to also cleanup some flake8 error on this file? Perhaps the whitespace error ones? $ impala-flake8 tests/benchmark/report_benchmark_results.py | grep E30 tests/benchmark/report_benchmark_results.py:233:1: E302 expected 2 blank lines, found 1 tests/benchmark/report_benchmark_results.py:255:1: E302 expected 2 blank lines, found 1 tests/benchmark/report_benchmark_results.py:265:1: E302 expected 2 blank lines, found 1 tests/benchmark/report_benchmark_results.py:301:1: E302 expected 2 blank lines, found 1 tests/benchmark/report_benchmark_results.py:326:7: E303 too many blank lines (2) tests/benchmark/report_benchmark_results.py:611:1: E302 expected 2 blank lines, found 1 tests/benchmark/report_benchmark_results.py:996:1: E302 expected 2 blank lines, found 1 tests/benchmark/report_benchmark_results.py:1000:1: E302 expected 2 blank lines, found 1 tests/benchmark/report_benchmark_results.py:1019:1: E302 expected 2 blank lines, found 1 tests/benchmark/report_benchmark_results.py:1022:1: E302 expected 2 blank lines, found 1 tests/benchmark/report_benchmark_results.py:1025:1: E302 expected 2 blank lines, found 1 tests/benchmark/report_benchmark_results.py:1028:1: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/20918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbde17f720b18d38dc2c2104ecf3fec807c1839d Gerrit-Change-Number: 20918 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 18 Jan 2024 04:15:48 +0000 Gerrit-HasComments: Yes
