Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20925 )
Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs ...................................................................... IMPALA-12711: Fix DDL errors are not shown in impalad logs We use LOG_AND_RETURN_IF_ERROR to log the non-ok status of executing the DDL. However, when enable_async_ddl_execution is true (default), the returned status of ExecDdlRequest() and ExecLoadDataRequest() are about creating the async thread. It's not the error of executing the statement. If the DDL fails, no errors will be shown in impalad logs. This patch fixes it by logging the error when UpdateQueryStatus() is invoked by the async exec thread. A new parameter, 'log_error', is added to this method to control the logging behavior. It's false by default and only set to true when used in the async thread. Tests - Add e2e test to verify the error in logs Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40 Reviewed-on: http://gerrit.cloudera.org:8080/20925 Reviewed-by: Wenzhe Zhou <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M tests/metadata/test_ddl.py 3 files changed, 39 insertions(+), 10 deletions(-) Approvals: Wenzhe Zhou: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/20925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40 Gerrit-Change-Number: 20925 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
