Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20914 )
Change subject: IMPALA-12746: Bump jackson.databind to 2.15.3 ...................................................................... Patch Set 3: (2 comments) Changed the version to 2.15.3 http://gerrit.cloudera.org:8080/#/c/20914/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20914/3//COMMIT_MSG@7 PS3, Line 7: Bump jackson.databind to 2.15.0 > We should have a JIRA ticket. created IMPALA-12746 http://gerrit.cloudera.org:8080/#/c/20914/3/java/datagenerator/pom.xml File java/datagenerator/pom.xml: http://gerrit.cloudera.org:8080/#/c/20914/3/java/datagenerator/pom.xml@80 PS3, Line 80: <artifactId>jackson-databind</artifactId> > Is this addition actually needed? Do we directly use jackson-databind? Yes, it is used, so I think that it is better to explicitly depend on it: https://github.com/apache/impala/blob/ad0dc67482b10ef7a49a432a1bd46887d171800d/java/datagenerator/src/main/java/org/apache/impala/datagenerator/JsonToParquetConverter.java#L32 This was needed to reproduce the error from the conflict between jackson-core and jackson-databind version that came up in a different build environment. -- To view, visit http://gerrit.cloudera.org:8080/20914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8440426da1395045cf149aca0044286015861e5f Gerrit-Change-Number: 20914 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 23 Jan 2024 10:49:07 +0000 Gerrit-HasComments: Yes
