Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10186 )
Change subject: IMPALA-6920: fix inconsistencies with scanner thread tokens ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10186/4/be/src/runtime/thread-resource-mgr.h File be/src/runtime/thread-resource-mgr.h: http://gerrit.cloudera.org:8080/#/c/10186/4/be/src/runtime/thread-resource-mgr.h@34 PS4, Line 34: Conceptually, there is a fixed pool of threads that are shared between : /// query fragments. If there is only one fragment running, it can use the : /// entire pool, spinning up the maximum number of threads to saturate the : /// hardware. If there are multiple fragments, the CPU pool must be shared : /// between them. This seems to be using the term "pool" to mean something different than ThreadResourcePool. is there an easy reword to make it clearer what ThreadResourcePool is? (seems to be the "sub" pool for a fragment instance?) -- To view, visit http://gerrit.cloudera.org:8080/10186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16d31d72441aff7293759281d0248e641df43704 Gerrit-Change-Number: 10186 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Apr 2018 23:52:01 +0000 Gerrit-HasComments: Yes
