Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20916 )
Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20916/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/20916/1/tests/authorization/test_ranger.py@1191 PS1, Line 1191: for privilege in privileges: optional: I think that it would be easier to digest this function if some subfunctions were extracted, e.g. _test_grant_revoke_by_owner_on_db, _test_grant_revoke_by_owner_on_table ... to separate db/table/column/udf level tests http://gerrit.cloudera.org:8080/#/c/20916/1/tests/authorization/test_ranger.py@1208 PS1, Line 1208: # .format(privilege, unique_database, grantee_type, grantee)) Are these commented logs intentionally in the code? http://gerrit.cloudera.org:8080/#/c/20916/1/tests/authorization/test_ranger.py@1288 PS1, Line 1288: database In this case only the table metadata is reloaded. -- To view, visit http://gerrit.cloudera.org:8080/20916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibac5335c65a860963ef0ccd890a926af80585ef3 Gerrit-Change-Number: 20916 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 24 Jan 2024 16:38:06 +0000 Gerrit-HasComments: Yes
