gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 )
Change subject: IMPALA-12503: Support date data type for predicates for external data source table ...................................................................... Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/20915/7/testdata/bin/setup-impala-env.sh File testdata/bin/setup-impala-env.sh: http://gerrit.cloudera.org:8080/#/c/20915/7/testdata/bin/setup-impala-env.sh@44 PS7, Line 44: VARCHAR(10) > change to STRING Done http://gerrit.cloudera.org:8080/#/c/20915/7/testdata/bin/setup-impala-env.sh@51 PS7, Line 51: DROP TABLE IF EXISTS AllTypesCaseSensitiveNames_impala; : CREATE TABLE AllTypesCaseSensitiveNames_impala > Impala is case insensitive. Don't need to create this table Done http://gerrit.cloudera.org:8080/#/c/20915/7/testdata/bin/setup-impala-env.sh@63 PS7, Line 63: VARCHAR(10) > change to STRING Done http://gerrit.cloudera.org:8080/#/c/20915/7/testdata/bin/setup-impala-env.sh@71 PS7, Line 71: # Load data to jdbc table : cat ${IMPALA_HOME}/testdata/target/AllTypes/* > /tmp/impala_jdbc_alltypes.csv : : hadoop fs -mkdir -p hdfs:///tmp/ : hadoop fs -put /tmp/impala_jdbc_alltypes.csv \ : hdfs:///tmp/impala_jdbc_alltypes >/dev/null 2>&1 : : impala-shell -i localhost -q "use functional;load data inpath 'hdfs:///tmp/\ : impala_jdbc_alltypes' into table alltypes_impala;" : : hadoop fs -put /tmp/impala_jdbc_alltypes.csv hdfs:///tmp/impala_jdbc_alltypes >\ : /dev/null 2>&1 : : impala-shell -i localhost -q "use functional;load data inpath 'hdfs:///tmp/\ : impala_jdbc_alltypes' into table AllTypesCaseSensitiveNames_impala;" > load data from existing table with 'insert select' as Done http://gerrit.cloudera.org:8080/#/c/20915/7/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables.test File testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables.test: http://gerrit.cloudera.org:8080/#/c/20915/7/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables.test@74 PS7, Line 74: AllTypesCaseSensitiveNames_impala > still use alltypes_impala since we don't need to create AllTypesCaseSensiti Done http://gerrit.cloudera.org:8080/#/c/20915/7/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables.test@83 PS7, Line 83: where float_col = 0 > it was fixed after changing the way to load data from existing table with ' Done http://gerrit.cloudera.org:8080/#/c/20915/7/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables.test@226 PS7, Line 226: limit 5 > change to 'order by id limit 5' to get result consistently Done http://gerrit.cloudera.org:8080/#/c/20915/7/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables.test@240 PS7, Line 240: limit 5 > change to 'order by id limit 5' to get result consistently Done -- To view, visit http://gerrit.cloudera.org:8080/20915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf13cbefaad812a0f78755c5791d82b24a3395e4 Gerrit-Change-Number: 20915 Gerrit-PatchSet: 7 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2024 18:18:31 +0000 Gerrit-HasComments: Yes
