Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20953 )
Change subject: IMPALA-12695: Crash with UNION with complex types ...................................................................... Patch Set 1: (1 comment) The code looks good to me (or at least I have no idea how to do it better :) ). The tests could be extended for zipping unnest. http://gerrit.cloudera.org:8080/#/c/20953/1/testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test File testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test: http://gerrit.cloudera.org:8080/#/c/20953/1/testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test@156 PS1, Line 156: item Can you also add tests with unnest() in select list /from clause,e.g in zipping-unnest-in-from-clause.test / zipping-unnest-in-select-list.test Quickly checked with v as (select arr1 from complextypes_arrays union all select arr1 from complextypes_arrays) , v2 as (select unnest(arr1) a from v) select * from v2 where a=1; it returns a not too friendly error message: ERROR: IllegalStateException: Failed analysis after expr substitution. CAUSED BY: ClassCastException: class org.apache.impala.analysis.NumericLiteral cannot be cast to class org.apache.impala.analysis.SlotRef (org.apache.impala.analysis.NumericLiteral and org.apache.impala.analysis.SlotRef are in unnamed module of loader 'app') another one crashes Impala: with v as (select arr1, arr2 from complextypes_arrays union all select arr1, arr2 from complextypes_arrays) , v2 as (select unnest(arr1) a1, unnest(arr2) a2 from v) select * from v2 where a2="one" -- To view, visit http://gerrit.cloudera.org:8080/20953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I340adc50e6d7cda6f59dacd7a46b6adc31635d46 Gerrit-Change-Number: 20953 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2024 19:40:01 +0000 Gerrit-HasComments: Yes
