Yida Wu has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20944 )
Change subject: IMPALA-12125: Support for dumping symbols from RPMs without separate symbols ...................................................................... IMPALA-12125: Support for dumping symbols from RPMs without separate symbols Some RPMs contain binaries with debug symbols with no separate debuginfo package needed. bin/dump_breakpad_symbols.py does not allow this combination, as it expects a corresponding symbol package. This adds a --no_symbol_pkg option to dump_breakpad_symbols.py to turn off the requirement that --pkg be combined with --symbol_pkg. Testing: - Tested with an RPM package with an unstripped impalad binary - Tested with the usual RPM + debuginfo RPM combination Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b Reviewed-on: http://gerrit.cloudera.org:8080/20944 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Yida Wu <wydbaggio...@gmail.com> --- M bin/dump_breakpad_symbols.py 1 file changed, 22 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Yida Wu: Verified -- To view, visit http://gerrit.cloudera.org:8080/20944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9589b0ed7855fe49c6989ec3dcc51a9e9c4f476b Gerrit-Change-Number: 20944 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
