Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20943 )
Change subject: IMPALA-12745: Skip parallel symbol dumping with RPM/DEB packages ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20943/1/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: http://gerrit.cloudera.org:8080/#/c/20943/1/bin/dump_breakpad_symbols.py@369 PS1, Line 369: status = 1 > Do we need a break here when something happens? Good point, let's have the behavior match the parallel case. Before the parallelism, this was the old behavior. I filed IMPALA-12766 to add a flag to get the old behavior that keeps going. -- To view, visit http://gerrit.cloudera.org:8080/20943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2885a9cfb36a4f616b539599e7f744bd23552c3 Gerrit-Change-Number: 20943 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 29 Jan 2024 18:01:48 +0000 Gerrit-HasComments: Yes
