Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 )
Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml File docs/topics/impala_identifiers.xml: http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@54 PS2, Line 54: The maximum length of an identifier is currently 128 characters except for column names which > It's 767 characters for column names, the same is applied in hive. Ack. Double checked in Hive codes: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/resources/package.jdo#L24-L25 It's added in HIVE-1364. http://gerrit.cloudera.org:8080/#/c/20950/4/docs/topics/impala_identifiers.xml File docs/topics/impala_identifiers.xml: http://gerrit.cloudera.org:8080/#/c/20950/4/docs/topics/impala_identifiers.xml@62 PS4, Line 62: can contain unicode characters nit: This is talking about the first charactor. Let's use "can start with any unicode character". BTW, is it truth that column names can start with whitespaces? -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2024 07:47:21 +0000 Gerrit-HasComments: Yes
