Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20968 )
Change subject: IMPALA-12764: Fix Iceberg metadata table scan's LIMIT clause ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20968/1/be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc File be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/20968/1/be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc@198 PS1, Line 198: *eos = true; I think if we exit the loop because of row_batch->AtCapacity(), *eos should not be set to true, because we haven't reached the limit yet and there are more rows to scan. -- To view, visit http://gerrit.cloudera.org:8080/20968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea73716fe475c8b063235d2ae971a4074b8e2a20 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2024 07:53:28 +0000 Gerrit-HasComments: Yes
