Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20263 )
Change subject: WIP IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. ...................................................................... Patch Set 7: (4 comments) Thanks for spliting the patch! http://gerrit.cloudera.org:8080/#/c/20263/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20263/7//COMMIT_MSG@9 PS7, Line 9: independent linux packaging related content to package/CMakeLists.txt. Could you share the benifits of doing this? http://gerrit.cloudera.org:8080/#/c/20263/6/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/20263/6/package/bin/impala.sh@49 PS6, Line 49: > what do you mean? remove the else branch, or keep the content out of the if Replied at https://gerrit.cloudera.org/c/20921/7/package/bin/impala.sh#53 http://gerrit.cloudera.org:8080/#/c/20263/6/package/bin/impala.sh@109 PS6, Line 109: > Generally service startup tools (such as systemd, or the startup script for Let's continue the discussion at https://gerrit.cloudera.org/c/20921/7/package/bin/impala.sh#47 http://gerrit.cloudera.org:8080/#/c/20263/6/package/conf/catalogd_flags File package/conf/catalogd_flags: http://gerrit.cloudera.org:8080/#/c/20263/6/package/conf/catalogd_flags@a9 PS6, Line 9: > I don't want to write dead a path in default configurations, I found that ' Ack -- To view, visit http://gerrit.cloudera.org:8080/20263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 20263 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2024 08:22:12 +0000 Gerrit-HasComments: Yes
