Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20970 )
Change subject: IMPALA-12763: Union with string struct crashes in ASAN ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20970/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/20970/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3468 PS1, Line 3468: private static boolean typeHasStruct(Type type) { I think that Type.java would be a better place for this. There is already a containsCollection function: https://github.com/apache/impala/blob/eaa35b02507a834edd0d219343fd4bd075f21762/fe/src/main/java/org/apache/impala/catalog/Type.java#L251C18-L251C36 -- To view, visit http://gerrit.cloudera.org:8080/20970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id728f1254b74636be594a33313a478b0b77c7ae4 Gerrit-Change-Number: 20970 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2024 09:11:00 +0000 Gerrit-HasComments: Yes
