gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/20975 )
Change subject: IMPALA-12471 PART-2: skip mysql ext jdbc tests if setup environment fails. ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20975/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20975/2//COMMIT_MSG@10 PS2, Line 10: xfaile > nit: xfailed Done http://gerrit.cloudera.org:8080/#/c/20975/1/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/20975/1/tests/custom_cluster/test_ext_data_sources.py@172 PS1, Line 172: else: > nit: add a comment here like intermittent issue and need to reinstall mysql Done http://gerrit.cloudera.org:8080/#/c/20975/2/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/20975/2/tests/custom_cluster/test_ext_data_sources.py@173 PS2, Line 173: The mysql docker container creation and mysqld > nit: add more details Done -- To view, visit http://gerrit.cloudera.org:8080/20975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7829aed09d25ff3e636004f3d1f32ecc6f37299 Gerrit-Change-Number: 20975 Gerrit-PatchSet: 3 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2024 20:03:44 +0000 Gerrit-HasComments: Yes
