ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20490 )
Change subject: IMPALA-12448: Avoid getting stuck when refreshing a non-existent partition ...................................................................... Patch Set 30: (9 comments) Hi, Quanlong! Thank you for your reply! http://gerrit.cloudera.org:8080/#/c/20490/23/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/20490/23/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3266 PS23, Line 3266: > nit: Let's make this clear to be "catalog version" Ack http://gerrit.cloudera.org:8080/#/c/20490/23/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3277 PS23, Line 3277: > nit: Let's clear this to be "catalog version" Ack http://gerrit.cloudera.org:8080/#/c/20490/23/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3304 PS23, Line 3304: in order to ensure that its result set ('result') has been broad > nit: Let's clear this to be "Topic update for {} not found yet. Last sent c Ack http://gerrit.cloudera.org:8080/#/c/20490/23/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3324 PS23, Line 3324: > nit: Let's make this clear to be "topic update" Ack http://gerrit.cloudera.org:8080/#/c/20490/23/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3328 PS23, Line 3328: > nit: "topic update" Ack http://gerrit.cloudera.org:8080/#/c/20490/23/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3341 PS23, Line 3341: ForDeletes == -1) { > nit: "catalog version {} to be sent" Ack http://gerrit.cloudera.org:8080/#/c/20490/23/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3342 PS23, Line 3342: yet. Last se > nit: "topic update" Ack http://gerrit.cloudera.org:8080/#/c/20490/24/tests/custom_cluster/test_refresh_invalid_partition.py File tests/custom_cluster/test_refresh_invalid_partition.py: http://gerrit.cloudera.org:8080/#/c/20490/24/tests/custom_cluster/test_refresh_invalid_partition.py@72 PS24, Line 72: > flake8: E501 line too long (101 > 90 characters) Ack http://gerrit.cloudera.org:8080/#/c/20490/24/tests/custom_cluster/test_refresh_invalid_partition.py@86 PS24, Line 86: > flake8: E501 line too long (95 > 90 characters) Ack -- To view, visit http://gerrit.cloudera.org:8080/20490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887 Gerrit-Change-Number: 20490 Gerrit-PatchSet: 30 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Wed, 31 Jan 2024 03:47:41 +0000 Gerrit-HasComments: Yes
