Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20922 )
Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/20922/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20922/2//COMMIT_MSG@24 PS2, Line 24: is nit: are http://gerrit.cloudera.org:8080/#/c/20922/2//COMMIT_MSG@28 PS2, Line 28: muti nit: multi http://gerrit.cloudera.org:8080/#/c/20922/2/fe/src/main/java/org/apache/impala/catalog/SideloadTableStats.java File fe/src/main/java/org/apache/impala/catalog/SideloadTableStats.java: http://gerrit.cloudera.org:8080/#/c/20922/2/fe/src/main/java/org/apache/impala/catalog/SideloadTableStats.java@26 PS2, Line 26: nit: Could you add description for the new class? http://gerrit.cloudera.org:8080/#/c/20922/2/fe/src/main/java/org/apache/impala/catalog/SideloadTableStats.java@40 PS2, Line 40: public void addColumnStats(String colName, ColumnStatisticsData colStats) { add Preconditions check for the input parameters http://gerrit.cloudera.org:8080/#/c/20922/3/fe/src/main/java/org/apache/impala/common/RuntimeEnv.java File fe/src/main/java/org/apache/impala/common/RuntimeEnv.java: http://gerrit.cloudera.org:8080/#/c/20922/3/fe/src/main/java/org/apache/impala/common/RuntimeEnv.java@21 PS3, Line 21: nit: remove empty line http://gerrit.cloudera.org:8080/#/c/20922/3/fe/src/test/java/org/apache/impala/testutil/StatsJsonParser.java File fe/src/test/java/org/apache/impala/testutil/StatsJsonParser.java: http://gerrit.cloudera.org:8080/#/c/20922/3/fe/src/test/java/org/apache/impala/testutil/StatsJsonParser.java@90 PS3, Line 90: colType.substring(0, colType.indexOf("(") if colType contains "(", does it contains ")"? -- To view, visit http://gerrit.cloudera.org:8080/20922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaffddd70c2da8376ca6c40f65606bbac46c34de7 Gerrit-Change-Number: 20922 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 31 Jan 2024 21:17:53 +0000 Gerrit-HasComments: Yes
