Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 )
Change subject: IMPALA-12503: Support date data type for predicates for external data source table ...................................................................... Patch Set 13: (3 comments) Please add a test case for '=' with value like '1990-01-01', expect return 0 row. Add similar test cases for '<' and '>' to return 0 row. http://gerrit.cloudera.org:8080/#/c/20915/13/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DatabaseAccessor.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DatabaseAccessor.java: http://gerrit.cloudera.org:8080/#/c/20915/13/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DatabaseAccessor.java@36 PS13, Line 36: dateCol nit: rename to dateVal http://gerrit.cloudera.org:8080/#/c/20915/13/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java: http://gerrit.cloudera.org:8080/#/c/20915/13/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@218 PS13, Line 218: dateCol nit: rename to dateVal http://gerrit.cloudera.org:8080/#/c/20915/13/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test File testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test: http://gerrit.cloudera.org:8080/#/c/20915/13/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test@49 PS13, Line 49: ---- QUERY : # Create external JDBC DataSource table : DROP TABLE IF EXISTS alltypes_jdbc_datasource_2; : CREATE TABLE alltypes_jdbc_datasource_2 ( : id INT, : bool_col BOOLEAN, : tinyint_col TINYINT, : smallint_col SMALLINT, : int_col INT, : bigint_col BIGINT, : float_col FLOAT, : double_col DOUBLE, : date_col DATE, : string_col STRING, : timestamp_col TIMESTAMP) : PRODUCED BY DATA SOURCE TestJdbcDataSource( : '{"database.type":"IMPALA", : "jdbc.url":"jdbc:impala://$INTERNAL_LISTEN_HOST:21050/functional", : "jdbc.auth":"AuthMech=0", : "jdbc.driver":"com.cloudera.impala.jdbc.Driver", : "driver.url":"$FILESYSTEM_PREFIX/test-warehouse/data-sources/jdbc-drivers/ImpalaJDBC42.jar", : "dbcp.username":"impala", : "dbcp.password":"cloudera", : "table":"alltypes_with_date"}'); : ---- RESULTS : 'Table has been created.' still not removed -- To view, visit http://gerrit.cloudera.org:8080/20915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf13cbefaad812a0f78755c5791d82b24a3395e4 Gerrit-Change-Number: 20915 Gerrit-PatchSet: 13 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 01 Feb 2024 19:45:13 +0000 Gerrit-HasComments: Yes
