Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 )
Change subject: IMPALA-6522: [DOCS] Document Decimal V2 ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@197 PS13, Line 197: <p> > Let's move and replace this paragraph with the one on L208. Done http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@209 PS13, Line 209: Note that in memory and on disk for binary file formats, such as Parquet or Avro, > This is not quite accurate and redundant with L197. Let's replace this para Done http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@395 PS13, Line 395: <ul> > These points are not correct. For assignments, Impala is very strict. If th Made the second point clear. And changed "leading digits" to "precision". http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@431 PS13, Line 431: <codeph>DECIMAL</codeph>. An error returns. > An error is returned. Done -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 13 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Mon, 30 Apr 2018 17:08:02 +0000 Gerrit-HasComments: Yes
