Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20985 )
Change subject: IMPALA-12780: Only show non-default options in the catalog operations page ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20985/1/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java: http://gerrit.cloudera.org:8080/#/c/20985/1/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@170 PS1, Line 170: // Only show non-default options in the 'details' field. nit: I think it is good to put comment at CatalogService.thrift to update this code if TDdlQueryOptions is modified. Similar comment for TResetMetadataRequest and TUpdateCatalogRequest below. -- To view, visit http://gerrit.cloudera.org:8080/20985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie62d4b9e4d357e02764e7a62f4dc107de602e1a5 Gerrit-Change-Number: 20985 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 02 Feb 2024 18:14:19 +0000 Gerrit-HasComments: Yes
