Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20941 )
Change subject: IMPALA-12381: Set JDBC related properties in JDBC data source ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20941/2/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java: http://gerrit.cloudera.org:8080/#/c/20941/2/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@324 PS2, Line 324: // Add additional properties of DataSource with keys as lower case. : for (Map.Entry<String, String> entry : dsPropertyMap.entrySet()) { : combinedPropertyMap.put(entry.getKey().toLowerCase(), entry.getValue()); : } : } : if (!Strings.isNullOrEmpty(tblInitString)) { : // Add the properties from initString. For a previously contained property, : // the old value is replaced, e.g, the settings in the table overwrite the : // settings in DataSource. : try { : Map<String, String> tblPropertyMap = : JsonUtil.convertJSonToPropertyMap(tblInitString); : if (tblPropertyMap != null) { : for (Map.Entry<String, String> entry : tblPropertyMap.entrySet()) { : combinedPropertyMap.put(entry.getKey().toLowerCase(), entry.getValue()); : } : } : } catch (ImpalaRuntimeException e) { : // Return initString which is set in the table creation statement if it's : // invalid JSON string. This could happen for non JDBC data source. : return tblInitString; : } : } : if (combinedPropertyMap != null && combinedPropertyMap.size() > 0) { : return JsonUtil.convertPropertyMapToJSon(combinedPropertyMap); : } : return new String(""); : } : } : : > Can we reorganize this to: Done. -- To view, visit http://gerrit.cloudera.org:8080/20941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a0b5d9d7b06825842828c3722c2bcdb4eacccc8 Gerrit-Change-Number: 20941 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Sat, 03 Feb 2024 18:08:41 +0000 Gerrit-HasComments: Yes
