Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20993 )
Change subject: IMPALA-12784: Fix bug in ScanNode.getFilteredInputCardinality ...................................................................... Patch Set 1: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/20993/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20993/1//COMMIT_MSG@15 PS1, Line 15: fix nit: fixes http://gerrit.cloudera.org:8080/#/c/20993/1//COMMIT_MSG@17 PS1, Line 17: d nit: adds http://gerrit.cloudera.org:8080/#/c/20993/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/20993/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java@338 PS1, Line 338: return getLimit(); not related to the current fix, but shouldn't we return min(limit, inputCardinality_) in this case? -- To view, visit http://gerrit.cloudera.org:8080/20993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae41f0fe5907cfed6ac67c156e975cf9964a7559 Gerrit-Change-Number: 20993 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 05 Feb 2024 13:24:00 +0000 Gerrit-HasComments: Yes
