Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20999 )
Change subject: IMPALA-12787: Concurrent DELETE and UPDATE operations on Iceberg tables can be problematic ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20999/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20999/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@375 PS2, Line 375: rowDelta.validateNoConflictingDataFiles(); > Personally I like method chaining for Builder classes, in other cases I fin I don't like chaining so I am happy with keeping it the way it is -- To view, visit http://gerrit.cloudera.org:8080/20999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e581ea17fa8f6ccd9c87aaad1281bb694079f6e Gerrit-Change-Number: 20999 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Feb 2024 16:33:01 +0000 Gerrit-HasComments: Yes
