Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10248 )
Change subject: IMPALA-6070: Further improvements to test-with-docker. ...................................................................... Patch Set 1: (1 comment) Not a clean cherry-pick. See below. http://gerrit.cloudera.org:8080/#/c/10248/1/testdata/bin/run-hbase.sh File testdata/bin/run-hbase.sh: http://gerrit.cloudera.org:8080/#/c/10248/1/testdata/bin/run-hbase.sh@39 PS1, Line 39: export HBASE_HEAPSIZE=1g The fixed conflict was here: On master, we expected to add L39 under an unrelated IMPALA_MINICLUSTER_PROFILE conditional. On 2.x, that conditional is not here. I confirmed HBASE_HEAPSIZE is an env variable in our toolchain Hbase 1.2.0, so it seems OK to have this here. -- To view, visit http://gerrit.cloudera.org:8080/10248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c Gerrit-Change-Number: 10248 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 30 Apr 2018 21:32:05 +0000 Gerrit-HasComments: Yes
