Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20719 )
Change subject: IMPALA-12433: Share buffers among channels in KrpcDataStreamSender ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/20719/12/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/20719/12/be/src/runtime/krpc-data-stream-sender.cc@1056 PS12, Line 1056: u > nit: redundant space Done http://gerrit.cloudera.org:8080/#/c/20719/11/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/20719/11/be/src/runtime/row-batch.cc@271 PS11, Line 271: bool* is_compressed, int64_t size, TrackedString* compression_scratch) { > NM. I missed that this can be null. ack http://gerrit.cloudera.org:8080/#/c/20719/12/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/20719/12/be/src/runtime/row-batch.cc@280 PS12, Line 280: > nit: redundant underline Thanks for spotting, these used to be members in a previous iteration of the patch. -- To view, visit http://gerrit.cloudera.org:8080/20719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64854a350a9dae8bf3af11c871882ea4750e60b3 Gerrit-Change-Number: 20719 Gerrit-PatchSet: 13 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Thu, 08 Feb 2024 15:29:28 +0000 Gerrit-HasComments: Yes
