Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21028 )
Change subject: IMPALA-12805: Avoid problems of HIVE-27114 without configuration changes ...................................................................... Patch Set 1: (1 comment) Thanks for the help Andrew! I only left a minor comment on the commit message. I do not have any other suggestion. http://gerrit.cloudera.org:8080/#/c/21028/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21028/1//COMMIT_MSG@17 PS1, Line 17: non-empty nit: Should this be "empty" instead? At https://gerrit.cloudera.org/c/20937/2/fe/src/test/resources/hive-site.xml.py#71, we set the new Hive property to an empty string. Don't know if I missed anything. -- To view, visit http://gerrit.cloudera.org:8080/21028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c13efd0d1619930461829fd8ee1fea66fa764f5 Gerrit-Change-Number: 21028 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sat, 10 Feb 2024 21:28:01 +0000 Gerrit-HasComments: Yes
