Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21031 )

Change subject: Hierarchical metastore event processing
......................................................................


Patch Set 1:

(71 comments)

http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File 
fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@656
PS1, Line 656:     public PseudoCommitTxnEvent(CommitTxnEvent event, 
org.apache.hadoop.hive.metastore.api.Table table, List<Long> writeIds, 
List<Partition> partitions) {
line too long (154 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1013
PS1, Line 1013:   public static List<PseudoCommitTxnEvent> 
getPseudoCommitTxnEvents(CommitTxnEvent event) {
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@959
PS1, Line 959:     public PseudoCommitTxnEvent(CommitTxnEvent event, 
org.apache.hadoop.hive.metastore.api.Table table, List<Long> writeIds, 
List<Partition> partitions) {
line too long (154 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@989
PS1, Line 989:         if (table_.getPartitionKeysSize() > 0 && 
!MetaStoreUtils.isMaterializedViewTable(table_)) {
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@991
PS1, Line 991:             
catalogOpExecutor_.addCommittedWriteIdsAndReloadPartitionsIfExist(getEventId(), 
getDbName(), getTableName(),
line too long (120 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@992
PS1, Line 992:                 writeIds_, partitions_, "Processing event id: " 
+ getEventId() + ", event type: " + getEventType());
line too long (116 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@999
PS1, Line 999:           catalog_.reloadTableIfExists(getDbName(), 
getTableName(), "CommitTxnEvent", getEventId(), 
/*isSkipFileMetadataReload*/false);
line too long (135 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1002
PS1, Line 1002:           catalog_.addWriteIdsToTable(tableWriteId.getDbName(), 
tableWriteId.getTblName(), getEventId(), 
Collections.singletonList(tableWriteId.getWriteId()),
line too long (158 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1125
PS1, Line 1125:     try (MetaStoreClient client = 
event.getCatalogOpExecutor().getCatalog().getMetaStoreClient()) {
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1126
PS1, Line 1126:       List<WriteEventInfo> writeEventInfoList = 
client.getHiveClient().getAllWriteEventInfo(new 
GetAllWriteEventInfoRequest(event.getTxnId()));
line too long (143 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1129
PS1, Line 1129:         TableName tableName = new 
TableName(writeEventInfo.getDatabase(), writeEventInfo.getTable());
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1130
PS1, Line 1130:         tableNameToWritdeIds.computeIfAbsent(tableName, k -> 
new HashSet<>()).add(writeEventInfo.getWriteId());
line too long (111 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1133
PS1, Line 1133:         pseudoEvents.add(new PseudoAbortTxnEvent(event, 
entry.getKey(), new ArrayList<Long>(entry.getValue())));
line too long (112 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1138
PS1, Line 1138:           + "an invalidate metadata command to reset event 
processor.", event.getTxnId()), e); */
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1143
PS1, Line 1143:   public static List<PseudoCommitTxnEvent> 
getPseudoCommitTxnEvents(CommitTxnEvent event) {
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1145
PS1, Line 1145:     try (MetaStoreClientPool.MetaStoreClient client = 
event.getCatalogOpExecutor().getCatalog().getMetaStoreClient()) {
line too long (119 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1146
PS1, Line 1146:       List<WriteEventInfo> writeEventInfoList = 
client.getHiveClient().getAllWriteEventInfo(
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1151
PS1, Line 1151:         List<Long> writeIds = 
Collections.unmodifiableList(commitTxnMessage.getWriteIds());
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1155
PS1, Line 1155:           org.apache.hadoop.hive.metastore.api.Table tbl = 
commitTxnMessage.getTableObj(i);
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1161
PS1, Line 1161:           org.apache.hadoop.hive.metastore.api.Table tbl = 
commitTxnMessage.getTableObj(entry.getValue().get(0));
line too long (113 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1162
PS1, Line 1162:           pseudoEvents.add(new PseudoCommitTxnEvent(event, tbl, 
entry.getValue().stream().map(i -> 
writeIds.get(i)).collect(Collectors.toList()), entry.getValue().stream().map(i 
-> parts.get(i)).collect(Collectors.toList())));
line too long (226 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1167
PS1, Line 1167:         /* throw new 
MetastoreNotificationNeedsInvalidateException(debugString("Failed to "
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1169
PS1, Line 1169:             + "an invalidate metadata command to reset event 
processor.", event.txnId_), e); */
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java
File fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java:

http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@30
PS1, Line 30:   private static Map<String, DBEventExecutor> 
dbNameToEventExecutor = new ConcurrentHashMap<>();
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@40
PS1, Line 40:     AtomicLong skipEventId_ = new AtomicLong(-1); // skip all the 
events till this event id
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@64
PS1, Line 64:       return inEvents_.isEmpty() && tableProcessors_.isEmpty() && 
++removeCount_ ==  10; // TODO: Read config for threshold
line too long (123 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@68
PS1, Line 68:       TableEventExecutor tableEventExecutor = 
dbEventExecutor_.getOrAssignTableEventExecutor(event.getDbName(), 
event.getTableName());
line too long (134 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@69
PS1, Line 69:       TableProcessor tableProcessor = 
tableEventExecutor.getOrCreateTableProcessor(event.getDbName(), 
event.getTableName());
line too long (124 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@71
PS1, Line 71:         /* Table processor is created now. Prepend the pending db 
events to table processor */
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@76
PS1, Line 76:           LOG.info("[DB processor:{}] Event type: {}, id: {} 
dispatched to table processor: {}.{}", dbName_, barrierEvent.getEventType(), 
barrierEvent.getEventId(), dbName_, tableProcessor.tableName_);
line too long (201 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@80
PS1, Line 80:       LOG.info("[DB processor:{}] Event type: {}, id: {} 
dispatched to table processor: {}.{}", dbName_, event.getEventType(), 
event.getEventId(), dbName_, tableProcessor.tableName_);
line too long (183 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@88
PS1, Line 88:         LOG.info("[DB processor:{}] Event type: {}, id: {} 
dispatched to table processor: {}.{}", dbName_, barrierEvent.getEventType(), 
barrierEvent.getEventId(), dbName_, tableProcessor.tableName_);
line too long (199 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@101
PS1, Line 101:           
barrierEvent.getMetrics().getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).inc();
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@102
PS1, Line 102:           LOG.info("[DB processor:{}] Event type: {}, id: {} 
incremented skipped metric to {}", dbName_, barrierEvent.getEventType(), 
barrierEvent.getEventId(),
line too long (160 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@103
PS1, Line 103:               
barrierEvent.getMetrics().getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).getCount());
line too long (111 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@110
PS1, Line 110:               LOG.info("[DB processor:{}] Event type: {}, id: {} 
is processed and polled", dbName_, barrierEvent.getEventType(), 
barrierEvent.getEventId());
line too long (156 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@124
PS1, Line 124:           
tableProcessor.getTableEventExecutor().deleteTableProcessor(getDbName(), 
tableProcessor.getTableName());
line too long (114 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@206
PS1, Line 206:   private TableEventExecutor 
getOrAssignTableEventExecutor(String dbName, String tableName) {
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/DBEventExecutor.java@232
PS1, Line 232:     return eventType == MetastoreEventType.CREATE_DATABASE || 
eventType == MetastoreEventType.DROP_DATABASE || eventType ==  
MetastoreEventType.ALTER_DATABASE;
line too long (159 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1222
PS1, Line 1222:     protected CreateTableEvent(CatalogOpExecutor 
catalogOpExecutor, Metrics metrics, NotificationEvent event,
line too long (109 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1803
PS1, Line 1803:     protected DropTableEvent(CatalogOpExecutor 
catalogOpExecutor, Metrics metrics, NotificationEvent event,
line too long (107 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2919
PS1, Line 2919:     public PseudoAbortTxnEvent(AbortTxnEvent event, TableName 
tableName, List<Long> writeIds) {
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2935
PS1, Line 2935:                 + "continue. Issue an invalidate metadata 
command to reset event processor.",
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File 
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:

http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@667
PS1, Line 667:       dbEventExecutors_.add(new 
DBEventExecutor(String.valueOf(i), maxTableEventExecutors));
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@705
PS1, Line 705:     // Cleanup db event executors for any stale db processors 
that have exceeded threshold to remove
line too long (100 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@711
PS1, Line 711:       List<MetastoreShim.PseudoCommitTxnEvent> 
pseudoCommitTxnEvents = 
MetastoreShim.getPseudoCommitTxnEvents((MetastoreShim.CommitTxnEvent)event);
line too long (147 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@712
PS1, Line 712:       for (MetastoreShim.PseudoCommitTxnEvent 
pseudoCommitTxnEvent : pseudoCommitTxnEvents) {
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@713
PS1, Line 713:         DBEventExecutor dbEventExecutor = 
getOrAssignEventExecutor(pseudoCommitTxnEvent.getDbName());
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@717
PS1, Line 717:       List<MetastoreEvents.PseudoAbortTxnEvent> 
pseudoAbortTxnEvents = 
MetastoreShim.getPseudoAbortTxnEvents((MetastoreEvents.AbortTxnEvent)event);
line too long (147 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@718
PS1, Line 718:       for (MetastoreEvents.PseudoAbortTxnEvent 
pseudoAbortTxnEvent : pseudoAbortTxnEvents) {
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@719
PS1, Line 719:         DBEventExecutor dbEventExecutor = 
getOrAssignEventExecutor(pseudoAbortTxnEvent.getDbName());
line too long (100 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@722
PS1, Line 722:     } else if (event instanceof MetastoreEvents.AlterTableEvent 
&& ((MetastoreEvents.AlterTableEvent) event).isRename_) {
line too long (121 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@724
PS1, Line 724:       MetastoreEvents.AlterTableEvent alterEvent = 
(MetastoreEvents.AlterTableEvent) event;
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@726
PS1, Line 726:       
pseudoDropTableEvent.setEventType(MetastoreEvents.MetastoreEventType.DROP_TABLE.toString());
line too long (98 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@731
PS1, Line 731:       DBEventExecutor dbEventExecutor = 
getOrAssignEventExecutor(alterEvent.getBeforeTable().getDbName());
line too long (106 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@732
PS1, Line 732:       dbEventExecutor.enqueue(new 
MetastoreEvents.DropTableEvent(event.catalogOpExecutor_, event.metrics_, 
pseudoDropTableEvent, alterEvent.getBeforeTable()));
line too long (159 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@735
PS1, Line 735:       
pseudoCreateTableEvent.setEventType(MetastoreEvents.MetastoreEventType.CREATE_TABLE.toString());
line too long (102 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@741
PS1, Line 741:       dbEventExecutor.enqueue(new 
MetastoreEvents.CreateTableEvent(event.catalogOpExecutor_, event.metrics_, 
pseudoCreateTableEvent, alterEvent.getAfterTable()));
line too long (162 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1060
PS1, Line 1060:         LOG.warn(String.format("Total outstanding events to 
process exceeds threshold. Not fetching events until number of outstanding 
events go below the threshold"));
line too long (168 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java
File fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java:

http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@46
PS1, Line 46:     AtomicLong skipEventId_ = new AtomicLong(-1); // used to skip 
all the events till this drop table event id
line too long (110 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@50
PS1, Line 50:     public TableProcessor(TableEventExecutor tableEventExecutor, 
String dbName, String tableName) {
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@74
PS1, Line 74:       return events_.isEmpty() && ++removeCount_ ==  10; // TODO: 
Read config for threshold
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@88
PS1, Line 88:                 LOG.info("[Table processor:{}.{}] Event type: {}, 
id: {} barrier reached", dbName_, tableName_, event.getEventType(), 
event.getEventId());
line too long (154 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@95
PS1, Line 95:             // Increment EVENTS_SKIPPED_METRIC for table event 
when its processing is skipped
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@96
PS1, Line 96:             
event.getMetrics().getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).inc();
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@97
PS1, Line 97:             LOG.info("[Table processor:{}.{}] Event type: {}, id: 
{} incremented skipped metric to {}", dbName_, tableName_, 
event.getEventType(), event.getEventId(),
line too long (166 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@98
PS1, Line 98:                 
event.getMetrics().getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).getCount());
line too long (106 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@104
PS1, Line 104:                 LOG.info("[Table processor:{}.{}] Event type: 
{}, id: {} waiting to be processed on DB processor", dbName_, tableName_, 
event.getEventType(), event.getEventId());
line too long (178 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@109
PS1, Line 109:               // Do not increment EVENTS_SKIPPED_METRIC for db 
barrier event in table processor
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@110
PS1, Line 110:               LOG.info("[Table processor:{}.{}] Event type: {}, 
id: {} barrier skipped", dbName_, tableName_, event.getEventType(), 
event.getEventId());
line too long (152 > 90)


http://gerrit.cloudera.org:8080/#/c/21031/1/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@115
PS1, Line 115:           LOG.info("[Table processor:{}.{}] Event type: {}, id: 
{} polled. LastProcessedEventId: {}, SkipEventId: {}", dbName_, tableName_, 
event.getEventType(), event.getEventId(), lastProcessedEventId_, skipEventId);
line too long (218 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/21031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6
Gerrit-Change-Number: 21031
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 13 Feb 2024 09:06:21 +0000
Gerrit-HasComments: Yes

Reply via email to