Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21005 )
Change subject: IMPALA-12790: Fix overestimation in ScanNode.getInputCardinality ...................................................................... IMPALA-12790: Fix overestimation in ScanNode.getInputCardinality ScanNode.getInputCardinality() can overestimate if LIMIT is large. If table cardinality stats exist and it is less than the LIMIT, then the table cardinality should be returned. This patch adds those fixes and more test cases under small-query-opt.test. This also moves tests added by IMPALA-5602 to small-query-opt.test since only PlannerTest.testSmallQueryOptimization runs with EXEC_SINGLE_NODE_ROWS_THRESHOLD > 0. Testing: - Pass FE tests. Change-Id: Icc5b39a7684fb8748185349d0b80baf8dcd6b126 Reviewed-on: http://gerrit.cloudera.org:8080/21005 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/planner/ScanNode.java M fe/src/main/java/org/apache/impala/util/MaxRowsProcessedVisitor.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test M testdata/workloads/functional-planner/queries/PlannerTest/small-query-opt.test M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test M tests/query_test/test_codegen.py 8 files changed, 293 insertions(+), 60 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icc5b39a7684fb8748185349d0b80baf8dcd6b126 Gerrit-Change-Number: 21005 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
