Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21035 )
Change subject: IMPALA-12818: Intermediate Result Caching plan node framework ...................................................................... Patch Set 1: (16 comments) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/main/java/org/apache/impala/planner/TupleCachePlanner.java File fe/src/main/java/org/apache/impala/planner/TupleCachePlanner.java: http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/main/java/org/apache/impala/planner/TupleCachePlanner.java@58 PS1, Line 58: // We may add some extra PlanNodes in the tree, but nothing we do will impact the number line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java File fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java: http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@55 PS1, Line 55: verifyIdenticalCacheKeys("select id from functional.alltypes", "select id from functional.alltypes"); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@56 PS1, Line 56: verifyDifferentCacheKeys("select id from functional.alltypes", "select id from functional.alltypestiny"); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@58 PS1, Line 58: // verifyDifferentCacheKeys("select id from functional.alltypes", "select int_col from functional.alltypes"); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@59 PS1, Line 59: verifyDifferentCacheKeys("select id from functional.alltypes", "select id from functional_parquet.alltypes"); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@60 PS1, Line 60: verifyDifferentCacheKeys("select id from functional.alltypes", "select id from functional.alltypes where id = 1"); line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@61 PS1, Line 61: verifyDifferentCacheKeys("select id from functional.alltypes where id = 1", "select id from functional.alltypes where id = 2"); line too long (131 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@64 PS1, Line 64: // verifyIdenticalCacheKeys("select id from functional.alltypes", "select id from functional.alltypes a"); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@65 PS1, Line 65: verifyIdenticalCacheKeys("select id from functional.alltypes", "select id as a from functional.alltypes"); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@73 PS1, Line 73: // verifyCacheIneligible("select id from functional.alltypes where id < 7300 * rand()"); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@74 PS1, Line 74: // verifyCacheIneligible("select id from functional.alltypes where id < 7300 * random()"); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@75 PS1, Line 75: // verifyCacheIneligible("select id from functional.alltypes where string_col != uuid()"); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@78 PS1, Line 78: // now()/current_date()/current_timestamp()/unix_timestamp()/utc_timestamp()/timeofday() line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@79 PS1, Line 79: // verifyCacheIneligible("select timestamp_col from functional.alltypes where timestamp_col < now()"); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@80 PS1, Line 80: // verifyCacheIneligible("select timestamp_col from functional.alltypes where timestamp_col < current_timestamp()"); line too long (120 > 90) http://gerrit.cloudera.org:8080/#/c/21035/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@81 PS1, Line 81: // verifyCacheIneligible("select date_col from functional.date_tbl where date_col < current_date()"); line too long (105 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f36a87dcce6efd5d1e1f0bc04009bf009b1961 Gerrit-Change-Number: 21035 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Thu, 15 Feb 2024 00:55:26 +0000 Gerrit-HasComments: Yes
