Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10247 )
Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10247/1/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/10247/1/be/src/rpc/thrift-util.cc@205 PS1, Line 205: (e.getType() == TTransportException::NOT_OPEN && : strstr(e.what(), "ECONNRESET") != nullptr); As discussed offline, this may not be applicable anymore with the recent upgrade of Thrift to 0.9.3 (https://github.com/apache/thrift/blob/0.9.3/lib/cpp/src/thrift/transport/TSocket.cpp#L582-L584). The upgrade of Thrift was only applied to master but not 2.x so this patch may still be valid for 2.x. I wonder if it makes sense to #ifdef it in the code somehow. -- To view, visit http://gerrit.cloudera.org:8080/10247 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2 Gerrit-Change-Number: 10247 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Mon, 30 Apr 2018 23:00:57 +0000 Gerrit-HasComments: Yes
