Noemi Pap-Takacs has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21026 )

Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to 
list Iceberg Metadata tables
......................................................................


Patch Set 5:

(1 comment)

Nice patch, Daniel and thank you for the new syntax!

http://gerrit.cloudera.org:8080/#/c/21026/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
File 
testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test:

http://gerrit.cloudera.org:8080/#/c/21026/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@879
PS5, Line 879: # Omitting "metadata" results in an error.
             : show tables in functional_parquet.iceberg_query_metadata;
             : ---- CATCH
             : ParseException: Syntax error in line 1:
             : show tables in functional_parquet.iceberg_query_metadata
This test case would fit better in ParserTest.java.



--
To view, visit http://gerrit.cloudera.org:8080/21026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide10ccf10fc0abf5c270119ba7092c67e712ec49
Gerrit-Change-Number: 21026
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tma...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 14:34:28 +0000
Gerrit-HasComments: Yes

Reply via email to