Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21038 )
Change subject: IMPALA-12824: Adds built-in functions prettyprint_duration and prettyprint_bytes. ...................................................................... Patch Set 8: Code-Review+1 (3 comments) LGTM http://gerrit.cloudera.org:8080/#/c/21038/8/be/src/exprs/string-functions.h File be/src/exprs/string-functions.h: http://gerrit.cloudera.org:8080/#/c/21038/8/be/src/exprs/string-functions.h@239 PS8, Line 239: /// Converts microseconds stored as an integer value into human readable time durations. nanoseconds? http://gerrit.cloudera.org:8080/#/c/21038/8/be/src/exprs/string-functions.h@240 PS8, Line 240: microseconds nanoseconds? if is is nanoseconds then example result also needs changing. http://gerrit.cloudera.org:8080/#/c/21038/8/tests/query_test/test_prettyprint_duration.py File tests/query_test/test_prettyprint_duration.py: http://gerrit.cloudera.org:8080/#/c/21038/8/tests/query_test/test_prettyprint_duration.py@23 PS8, Line 23: class TestPrettyPrintDuration(ImpalaTestSuite): I don't know maybe this could have been combined with TestPrettyPrintBytes but don't change it now -- To view, visit http://gerrit.cloudera.org:8080/21038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e76632ce21ad2ca5df474160338699a542a6913 Gerrit-Change-Number: 21038 Gerrit-PatchSet: 8 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 20 Feb 2024 22:25:21 +0000 Gerrit-HasComments: Yes
