Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20951 )
Change subject: IMPALA-12598: Allow multiple equality field id lists for Iceberg tables ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/20951/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/20951/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@520 PS5, Line 520: */ > Nit: If you made equalityDeletesRecordCount_ a parameter you could write a Done http://gerrit.cloudera.org:8080/#/c/20951/5/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/20951/5/testdata/data/README@850 PS5, Line 850: primary key(i) > Impala doesn't do anything with this clause, right? ATM you are right, however I have a working PoC for IMPALA-12729 where I can populate the identifier-field-ids with primary keys so for this test I used that dev Impala to create the table. Since Nifi is not able to create tables, I did't want to involve 3 engines for this test: 1) create with Flink 2) populate with Nifi 3) query with Impala. http://gerrit.cloudera.org:8080/#/c/20951/5/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test File testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test: http://gerrit.cloudera.org:8080/#/c/20951/5/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test@1583 PS5, Line 1583: cardinality=8 > Would be nice to fix IMPALA-11797 later to get better cardinalities. Or, if I opened a jira for eq-deletes similarly to IMPALA-12371: IMPALA-12826 -- To view, visit http://gerrit.cloudera.org:8080/20951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e52d7a5800bf1b479f0c234679be92442d09f79 Gerrit-Change-Number: 20951 Gerrit-PatchSet: 7 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2024 13:31:05 +0000 Gerrit-HasComments: Yes
